Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global pnpm check 'no dependencies' #1292

Closed
ekwoka opened this issue Apr 5, 2023 · 8 comments
Closed

global pnpm check 'no dependencies' #1292

ekwoka opened this issue Apr 5, 2023 · 8 comments
Labels

Comments

@ekwoka
Copy link

ekwoka commented Apr 5, 2023

Screenshot 2023-04-05 at 10 56 51 AM

When running ncu -gp pnpm it finds no dependencies. This started, as far as I can tell only in the last day or two.

Could this be related to the updates in pnpm 8? As you can see, it seems to have no found updates to even see that ncu is updated (manually updating that one did not fix it)

ncu -g still works fine.

@raineorshine
Copy link
Owner

Oops! That must be a regression. Thanks for letting me know. I will look into it.

raineorshine added a commit that referenced this issue Apr 5, 2023
@raineorshine
Copy link
Owner

raineorshine commented Apr 5, 2023

Here's what happened: Commit 09c9680 added the ability to override boolean options in the cli, e.g. --peer false. Unfortunately this broke the use of combining boolean short flags.

I have reverted the offending commit and added tests to prevent this from happening again. Published in v16.10.3.

@ekwoka
Copy link
Author

ekwoka commented Apr 6, 2023

Confirmed, works :D

@diegocr
Copy link

diegocr commented Aug 14, 2023

ncu -g still works fine.

By any chance fixing this for pnpm broke using ncu -g ? because it's no longer working for me, been a while this way and patiently waiting for it to be fixed, but since it hasn't happened yet just thought on commenting here about it :)

Edit: i am now realizing all that was made to fix this was reverting a commit, so... must not be related, dunno if there were some other commits at the time that may broke this, or if it's something tied to my system... i.e. win11, nodejs installed on a non-C drive, dunno what other troubleshooting details i can provide, lmk.

@raineorshine
Copy link
Owner

@diegocr It's not related to this issue, but it is possible there was a different regression. It's going to be tough to identify without a minimum reproduction case, but if you open a new issue I can provide some troubleshooting tips.

@diegocr
Copy link

diegocr commented Aug 14, 2023

Thanks for the prompt response.

Just thought about running ncu --verbose -g and found where the problem is, there i do see a options.prefix pointing to %APPDATA%\npm but that path here doesn't exists (because nodejs is not installed on the system drive, as pointed)

I made a symlink and got ncu -g working again, but... perhaps ncu should be using the NODE_PATH environment variable for this "prefix" value (?)

fwiw, on ~/.npmrc i do have:

prefix=D:\\nodejs
cache=R:\Temp\npm-cache

and NODE_PATH does point to D:\nodejs\node_modules (the before mentioned symlink does point to this path)

PS: Could still file a new ticket/issue if you think it's still needed ;)

@raineorshine
Copy link
Owner

@diegocr Thanks! That's very informative.

Yes, if you could create a new ticket with that information we can track it there. I will think if there could be any regressions, but it makes sense to use NODE_PATH if it exists.

@diegocr
Copy link

diegocr commented Aug 19, 2023

Here you go: #1315

Cheers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants