-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace option doesn't seem to work #1304
Comments
You should specify the package folder name rather than the full package name:
However, I see no reason why we should not also allow the package name. Sorry for the confusion.
This sounds like a bug. I'm not as familiar with the |
Nice, this works!! |
Yes, I agree. I think the behavior may even be a regression from #1217. I think it is ignoring entire workspaces instead of ignore local dependencies on workspaces. |
You should be able to do Published in |
npm-check-updates
node >= 14.14
Description
Hey, thanks for taking time to do this package, it's really useful!! 😊
I seem to have some problems with using it though in NPM workspaces, I tried reading through the README and through your pitch for the new API in #896 (comment) but I can't make it work.
Steps to Reproduce
Steps:
git clone git@github.com:Quramy/npm-ts-workspaces-example.git
&&cd npm-ts-workspaces-example
&&npm install
npx npm-check-updates@16.10.12 -w @quramy/x-cli
(you can also install it globally and run it, both will not work)Current Behavior
Expected Behavior
Notes
-ws
works fine, likenpm exec npm-check-updates@16.10.12 -- -ws
--peer
option works incorrectly for the workspaces as it fails to find packages installed in the local node_modules folder of a particular workspace subpackage. Like the way node_modules resolution in workspaces works is:Currently it just tries to find them in the root node_modules folder but it doesn't check Package-A and Package-B node_modules .
The text was updated successfully, but these errors were encountered: