Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore git dependencies #5

Closed
uipoet opened this issue Nov 1, 2013 · 4 comments
Closed

Ignore git dependencies #5

uipoet opened this issue Nov 1, 2013 · 4 comments

Comments

@uipoet
Copy link

uipoet commented Nov 1, 2013

When a dependency uses a direct link instead of a version string:

There was an error determining the latest package versions: Error: 404 Not Found: 

What should happen is this case should be ignored so the other dependencies can be checked.

@tjunnone
Copy link
Collaborator

tjunnone commented Nov 2, 2013

I tried all of the formats as described on https://npmjs.org/doc/json.html#Git-URLs-as-Dependencies and it seems to work OK (in fact, entirely by happy accident it actually manages to upgrade git tags of the form git+ssh://git@github.com:myaccount/myprivate.git#v1.0.0 to git+ssh://git@github.com:myaccount/myprivate.git#v2.0.0)

Could you please paste an example of your problematic package.json? Thanks!

@uipoet
Copy link
Author

uipoet commented Nov 2, 2013

I hadn't considered questioning the format of the git tag, itself. This was happening with an internal file specified by another engineer with the form:

git://github.com/myaccount/myprivate.git#v0.1.0

@kud
Copy link

kud commented Sep 29, 2014

Yes, lines like "jQuery.serializeObject": "git://github.com/hongymagic/jQuery.serializeObject#5c5957f0895ed283f3373065e46a86490e1b966c", should be ignored.

@tjunnone
Copy link
Collaborator

tjunnone commented Dec 7, 2014

Thanks for the report, a fix has been merged and will be released shortly.

@tjunnone tjunnone closed this as completed Dec 7, 2014
raineorshine pushed a commit that referenced this issue Aug 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants