chore(fix post commit): fixes post commit hooks borking the developer machine #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raineorshine
requested changes
Dec 10, 2022
.husky/post-commit
Outdated
Comment on lines
16
to
22
| npm run lint:src 2>&1 | sed 1,4d || notify "Lint Error" & | ||
| npm run lint:src 2>&1 | sed 1,4d || notify "Lint Error" |
There was a problem hiding this comment.
The & is actually intentional. I often perform several commits very quickly (such as several small amends), and I prefer not to be slowed down by running the linter synchronously.
When the linter completes in the background, I get a notification and can then easily fix the linter error and amend the last commit.
There was a problem hiding this comment.
hmmm, ok I've pushed an alternative solution where the lint output skips the terminal entirely and as many errors as possible get shown in the notification.
…erminal To achieve this we pipe the output to a bg task *and* display the output in the notification, with some useful identifying output to tell us which commit we broke.
doublethefish
force-pushed
the
chore/fix_post_commit
branch
from
07734ec
to
27be71c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.