Query logged user only once. Also fixed wrong name of variable used i…

…n loop.
rainerborene · Dec 22, 2010 · deb4164 · deb4164
1 parent daac46f
commit deb4164
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/symphony/lib/core/class.symphony.php b/symphony/lib/core/class.symphony.php
@@ -395,6 +395,9 @@ public function logout(){
 		 * @see core.Cookie#expire()
 		 */
 		public function isLoggedIn(){
+			// Ensures that we're in the real world.. Also reduces three queries from database
+			if (is_null(self::$_instance)) return;   
+
 			if ($this->Author) return true;
 
 			$username = self::$Database->cleanValue($this->Cookie->get('username'));

diff --git a/symphony/lib/toolkit/class.author.php b/symphony/lib/toolkit/class.author.php
@@ -210,7 +210,7 @@ public function verifyToken($token){
 		 */
 		public function loadAuthor($id){
 			if(!is_object(Symphony::Database()) || !is_numeric($id)) return false;
-
+			
 			$row = Symphony::Database()->fetchRow(0, "SELECT * FROM `tbl_authors` WHERE `id` = '$id' LIMIT 1");
 
 			if(!is_array($row) || empty($row)) return false;

diff --git a/symphony/lib/toolkit/class.authormanager.php b/symphony/lib/toolkit/class.authormanager.php
@@ -185,8 +185,9 @@ public static function fetchByUsername($username){
 
 			$author = new Author;
 
-			foreach($rec as $field => $val)
+			foreach($records as $field => $val) {
 				$author->set($field, $val);
+			}
 
 			return $author;
 		}