Release: ready retries #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the extension automatically reconnects after a connection failure, it sends its current state to the server. However, it seems that under certain circumstances the server will keep around a "zombie" connection (that could be "ready") until it times out, so the new connection can't move to "ready" until the old connection clears (since we enforce that only one connection can be "ready" per worker). In this case, it makes sense to retry for a while instead of alerting the user. (Manual state updates won't retry under any circumstances.) My only concern is that this introduces a mismatch between the extension state and the server state, which could be hard to debug if something goes wrong. But I can't think of a better alternative. Fixes #752
Retry "ready" state updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.