Context menu #763
Context menu #763
Conversation
|
just wondering, why don't we also put the settings in the options page (the one in the extension settings)? |
|
if we do the settings in the extension's options page then it will break the goal to keep up with rolling updates from the server because of the complication of having to host 2 files, one for options page and other for extension's main.js. It's easier to handle npm module by building it on the server and serving just one file, main.js to the extension. |
|
@sweeneyapps looks like the menu items are duplicated for some reason:
|
| @@ -154,6 +156,14 @@ export const mockChrome = (opts = {}) => { | |||
| setTimeout(() => callback(profileUserInfo)); | |||
| }, | |||
| }; | |||
| const contextMenus = { | |||
There was a problem hiding this comment.
Can you add a space above here for consistency?
| const contextMenus = { | ||
| create: (option, callback) => { | ||
| createdMenus.push(option); | ||
| if (option.checked) checkedMenus.push(option); |
There was a problem hiding this comment.
Use braces here (I always get nervous about brace-less if statements).
There was a problem hiding this comment.
thanks.. now i'm working on it..
| @@ -14,7 +14,6 @@ export const actions = deepFreeze({ | |||
| CHECK_STATE: 'CHECK_STATE', | |||
| SET_PLUGIN_VERSION: 'SET_PLUGIN_VERSION', | |||
| SET_WORKER_PROFILE: 'SET_WORKER_PROFILE', | |||
| RATE_LIMIT_EXCEEDED: 'RATE_LIMIT_EXCEEDED', | |||
There was a problem hiding this comment.
馃憤 thanks for catching that
|
right now, I'm hunting down the duplication bug.. I was able to reproduce the bug by reloading the plugin inside the console. |
|
I fixed the bug and I still have to write a test for it so when I get home later today, I'll work on it. |
|
bugfix done! :) Also with additional code to rebuild the menu w/ correct setting after tester set options on their profile page. |
|
How can I get this context menu Thanks |
|
@majulink |
| }); | ||
| }; | ||
|
|
||
| const createContextMenu = (option) => { |
There was a problem hiding this comment.
There will be a period between when the backend JS is loaded and people's plugins have updated when the extension won't have the contextMenus privilege. I checked and it looks like chrome.contextMenus is undefined in that case, so this will blow up. Can you add a check and maybe just return if chrome.contexteMenus is undefined?
There was a problem hiding this comment.
good idea.. will do.
This is for issue #743, Context Menu under Rainforest Icon 馃憤
It will build context menu at startup and will make sure radio is checked on sub-menu from each option setting.
The context menu will set options for Confirm Work Assignment, Notification Sound, and Sound Repeat. After setting options on the context menu, it will make sure it's saved on chrome sync storage.
@shosti