Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled plugin still renders /sitemap.xml #58

Closed
CptMeatball opened this issue Dec 19, 2017 · 3 comments
Closed

Disabled plugin still renders /sitemap.xml #58

CptMeatball opened this issue Dec 19, 2017 · 3 comments
Labels
Status: Review Needed Type: Unconfirmed Bug

Comments

@CptMeatball
Copy link

CptMeatball commented Dec 19, 2017 •
edited
Loading

If you disable this plugin, it doesn't remove the URL from the known routes in the CMS.

October: 430
Sitemap: 1.0.8

Expected behavior:
Disabling sitemap in settings, should throw 404 when going to /sitemap.xml.

Actual behavior:
Disabling sitemap in settings, still shows the sitemap when going to /sitemap.xml
@aktaumag
Copy link

aktaumag commented Mar 31, 2018 •
edited
Loading

I agree. Now I'm looking for a way to solve the problem.

@LukeTowers
Copy link
Contributor

Looks like this is the line that's not working @aktaumag https://github.com/octobercms/october/blob/master/modules/system/classes/PluginManager.php#L202

@LukeTowers
Copy link
Contributor

@CptMeatball was this fixed by the recent changes in Build 466?

@LukeTowers LukeTowers reopened this Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Review Needed Type: Unconfirmed Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@daftspunk @CptMeatball @LukeTowers @aktaumag