Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translatable mediafinder field #192

Closed
MaxNozhkin opened this issue Nov 27, 2016 · 11 comments
Closed

Translatable mediafinder field #192

MaxNozhkin opened this issue Nov 27, 2016 · 11 comments

Comments

@MaxNozhkin
Copy link

How to use translatable mediafinder field? Is it possible?

@daftspunk daftspunk changed the title mediafinder field Translatable mediafinder field Nov 28, 2016
@daftspunk
Copy link
Member

This is a planned feature.

@LukeTowers
Copy link
Contributor

@daftspunk is this still a planned feature? What needs to happen for this?

@munxar
Copy link
Contributor

munxar commented Dec 17, 2017

@LukeTowers @daftspunk here you go: #325
Only thing I can't figure out is how it automagically renders as MLMediaFinder if used in a static page syntax field (like text and all others do). Any Idea?

@LukeTowers
Copy link
Contributor

@munxar
Copy link
Contributor

munxar commented Dec 17, 2017

@LukeTowers thats what I thought, but it doesn't work. $model->getTranslatableAttributes() does not return them...

@LukeTowers
Copy link
Contributor

@munxar did you mark the attribute it was getting stored in as translatable?

@munxar
Copy link
Contributor

munxar commented Dec 17, 2017

@LukeTowers it's a dynamic syntax field, usually I don't have to register anything. If I use it in a normal backend form with a model and the translatable attribute registered, it works.
Do I miss something?

@LukeTowers
Copy link
Contributor

Check how the pages plugin determines what fields to render and where it registers them as translatable.

@munxar
Copy link
Contributor

munxar commented Dec 17, 2017

Thanks, found it. So then this PR is complete. I'll have to add one to the Pages plugin too, to make it work for syntax fields. meanwhile {mlmediafinder}{/mlmediafinder} works.

@mjauvin
Copy link
Contributor

mjauvin commented May 5, 2019

@LukeTowers @munxar shouldn't that be closed? As far as I know, this is already implemented.

@mjauvin
Copy link
Contributor

mjauvin commented May 5, 2019

Closing this as it has been resolved by #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants