Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Exceptions Occuring with EmbedTimeline component #11

Closed
billyzduke opened this issue Jul 6, 2016 · 1 comment
Closed

Two Exceptions Occuring with EmbedTimeline component #11

billyzduke opened this issue Jul 6, 2016 · 1 comment

Comments

@billyzduke
Copy link

In Components\EmbedTimeline.php...

  1. Line 113, function getLangOptions() needs to be public, not protected.

  2. Lines 4 & 152, OctoberCMS case-sensitive alias for October\Rain\Support\Facades\Html class is "Html", not "HTML".

@daftspunk
Copy link
Member

Latest code shows these changes are already done.

https://github.com/rainlab/twitter-plugin/blob/master/components/EmbedTimeline.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants