Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to display a single tweet #4

Closed
jonpxpx opened this issue Apr 24, 2015 · 3 comments
Closed

Unable to display a single tweet #4

jonpxpx opened this issue Apr 24, 2015 · 3 comments

Comments

@jonpxpx
Copy link
Contributor

jonpxpx commented Apr 24, 2015

Due to values being switched to boolean if 1 or 0, tweet-limit doesn't allow you to set it to 1 and therefore returns all.

This isn't the most elegant way of fixing this, but I added

if($key != 'tweet-limit')

within

switch ($value) {
        case '1':
                if($key != 'tweet-limit')
                $value = 'true';
            break;
        case '0':
            $value = 'false';
            break;
        default:
            $value = $value;
            break;
}

To fix the issue.

@daftspunk
Copy link
Member

Can you submit this as a PR?

@jonpxpx
Copy link
Contributor Author

jonpxpx commented May 18, 2015

Never had to do one, but I will give it a go :)

daftspunk added a commit that referenced this issue Jul 4, 2015
Fixes #4 - Unable to display a single tweet
@jonpxpx
Copy link
Contributor Author

jonpxpx commented Jul 14, 2015

@daftspunk can you push an updated package to octobercms.com please? Not updating via the backend at the moment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants