Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

consolidateBy doesn't seem to work properly #530

Closed
Dieterbe opened this issue Feb 14, 2017 · 1 comment
Closed

consolidateBy doesn't seem to work properly #530

Dieterbe opened this issue Feb 14, 2017 · 1 comment
Assignees

Comments

@Dieterbe
Copy link
Contributor

Dieterbe commented Feb 14, 2017

demonstrated by nopzor in MT dashboard by looking at the chart for the incoming metrics.
Due to this being a counter, it might be special. I'm looking into it.

Confirmed so far by using fake data:

  • consolidate by min/max/avg by selecting different archive seems to work fine (rollups, not runtime consol)
  • runtime consolidation (only) seems to work fine
  • both combined seems to work fine

TODO:

  • check if it's different for counter, the specific metric in question
@Dieterbe Dieterbe self-assigned this Feb 14, 2017
@Dieterbe
Copy link
Contributor Author

Dieterbe commented Feb 14, 2017

yeah so the problem is that the metric is a counter, is which is derived via perSecond(), and we apply the consolidation in MT on the data before applying perSecond (wrong), in contrast to graphite which applies the consolidation later (right).

to make this a bit more visual, this is what the data looks like:
counter

changing the consolidateBy in MT will just shift the line, basically, whether you take the mins of each bucket or the maxes at each bucket or the avgs of each bucket, from one bucket to the next, the delta will be about the same, IOW after perSecond it looks about the same.

this is very similar to / the same as #463

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant