Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbPath isAbsolute logic #49

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

jvarho
Copy link

@jvarho jvarho commented Apr 21, 2024

This logic seems to have been inverted in the typescript rewrite.
At least using an absolute path no longer worked.

Old logic:

options.dbPath = path.isAbsolute(dbPath) ? dbPath : path.join(this.serverless.config.servicePath, dbPath);

As an aside, I haven't been able to make dbPath work with docker at all, but maybe that's unsupported?

@domdomegg domdomegg merged commit 8233f73 into raisenational:master Apr 21, 2024
@domdomegg
Copy link
Member

Thanks for the PR, good catch!

As an aside, I haven't been able to make dbPath work with docker at all, but maybe that's unsupported?

Yeah I'm not sure this is supported. Docker support has always been a bit flimsy, I think it would be nice to sort it all out but hasn't been a priority for me as I don't use it.

@jvarho jvarho deleted the fix-dbpath-isabsolute branch April 21, 2024 09:43
@domdomegg
Copy link
Member

Released in v0.2.52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants