Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling for context deadline in websocket loop #276

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

rmennes
Copy link
Collaborator

@rmennes rmennes commented Dec 15, 2023

No description provided.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ece7b91) 31.39% compared to head (9853950) 31.37%.

Files Patch % Lines
internal/clitrigger/websocket_trigger.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   31.39%   31.37%   -0.02%     
==========================================
  Files         108      108              
  Lines        9789     9793       +4     
==========================================
  Hits         3073     3073              
- Misses       6461     6465       +4     
  Partials      255      255              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmennes rmennes merged commit 3e77e23 into main Dec 15, 2023
1 of 3 checks passed
@rmennes rmennes deleted the fix/websocket-context-deadline branch December 15, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants