Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct theme application not working #183

Closed
3 of 10 tasks
tigerjack opened this issue Sep 3, 2022 · 9 comments · Fixed by #184
Closed
3 of 10 tasks

Direct theme application not working #183

tigerjack opened this issue Sep 3, 2022 · 9 comments · Fixed by #184
Assignees
Labels
bug Something isn't working released

Comments

@tigerjack
Copy link

Describe the bug

Cannot apply a theme directly; the menu list is always shown.

To Reproduce

Steps to reproduce the behavior:

  1. Installation
  • I run it via npx alacritty-themes
  • I installed it via npm i -g alacritty-themes (global installation)
  • I installed it via AUR
  1. Run alacritty-themes
  • Did you add params? yes, I type "alacritty-themes Ayu-Dark"
  • Did you add params? no, I just type "alacritty-themes" then click up/down keys
  1. See error
    image

Expected behavior

The theme should be directly applied.

Operating System:

  • Windows
  • Ubuntu
  • Pop Os
  • Arch
  • Other, which one?

Add your alacritty.yml content

env:
  TERM: alacritty
  LANG: "en_US.UTF-8"
  LC_CTYPE: en_US.UTF-8

font:
  normal:
    family: "monospace"

    style: Regular

  size: 11.0

colors:
  name: 3024 (dark)
  author: Chris Kempson
  primary:
    background: "#090300"
    foreground: "#a5a2a2"
  cursor:
    text: "#090300"
    cursor: "#a5a2a2"
  normal:
    black: "#090300"
    red: "#db2d20"
    green: "#01a252"
    yellow: "#fded02"
    blue: "#01a0e4"
    magenta: "#a16a94"
    cyan: "#b5e4f4"
    white: "#a5a2a2"
  bright:
    black: "#5c5855"
    red: "#db2d20"
    green: "#01a252"
    yellow: "#fded02"
    blue: "#01a0e4"
    magenta: "#a16a94"
    cyan: "#b5e4f4"
    white: "#f7f7f7"
theme: 3024.dark
@tigerjack tigerjack added the bug Something isn't working label Sep 3, 2022
@JuanVqz
Copy link
Collaborator

JuanVqz commented Sep 5, 2022

Hey @tigerjack, good call, do you want to contribute solving it? If not, that's okay, I just wanted to ask you.

@tigerjack
Copy link
Author

Hey @JuanVqz , unfortunately I cannot, I am sorry.

@JuanVqz
Copy link
Collaborator

JuanVqz commented Sep 5, 2022

That's okay, I'll try to fix it in the week, thanks for reporting it 🚀

@JuanVqz JuanVqz self-assigned this Sep 11, 2022
JuanVqz added a commit that referenced this issue Sep 11, 2022
now, if the direct theme application doesn't exist it fallback into the select theme action

fix #183
JuanVqz added a commit that referenced this issue Sep 11, 2022
now, if the direct theme application doesn't exist it fallback into the select theme action

fix #183
github-actions bot pushed a commit that referenced this issue Sep 11, 2022
## [5.1.1](v5.1.0...v5.1.1) (2022-09-11)

### Bug Fixes

* **cli:** fix direct theme application ([#184](#184)) ([2144b68](2144b68)), closes [#183](#183)
@rajasegar
Copy link
Owner

🎉 This issue has been resolved in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JuanVqz
Copy link
Collaborator

JuanVqz commented Sep 11, 2022

Hey, @tigerjack thank you for opening this issue we finally got it fixed, it would be great if you can try it again and let us know if now it is working as expected, just don't forget to download the last version 👍

@tigerjack
Copy link
Author

Hey @JuanVqz thanks for the quick fix. I am on ArchLinux and the latest version is still not on the AUR.

@JuanVqz
Copy link
Collaborator

JuanVqz commented Sep 13, 2022

@tigerjack unfortunately, AUR is maintained by external folks, we don't have control over it. If you know the repository please ask them to update the version.

In the other hand, you always can use npm install -g alacritty-themes to install it globally in your machine or using it with npx alacritty-themes Ayu-Dark

Hoping that works for you! 🫡

@tigerjack
Copy link
Author

The package is here and it has been updated recently. I confirm it works @JuanVqz

@JuanVqz
Copy link
Collaborator

JuanVqz commented Sep 19, 2022

The package is here and it has been updated recently. I confirm it works @JuanVqz

Thank you for following it up, we appreciate it. If have any idea or issue to report you are welcome 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants