Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by #70

Closed
wants to merge 2 commits into from
Closed

Sort by #70

wants to merge 2 commits into from

Conversation

return02
Copy link
Contributor

Implement sort by transform by a very simple range_partitioner.

This algorithm is almost the same with Apache Spark: partition all the data into ordered partitions and sort them separately.

There're still some work to be done:

  1. Find a better algorithm for building range_bounds.
  2. implement descending.
  3. use binary search in method get_partitions().
  4. perhaps F: SerFunc(&Self::Item) -> K + Clone is better than F: SerFunc(Self::Item) -> K.
  5. test corner case.

@iduartgomez
Copy link
Collaborator

iduartgomez commented Feb 26, 2020

Will review further later but could you rebase onto master (so cargo.lock change does not show) and run cargo fmt?

@return02
Copy link
Contributor Author

Will review further later but could you rebase onto master (so cargo.lock change does not show) and run cargo fmt?

sorry. I'll rebase master and use cargo fmt later.

@return02 return02 closed this Feb 27, 2020
@return02 return02 deleted the sort_by branch February 27, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants