Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update socketcan version #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

d21d3q
Copy link
Contributor

@d21d3q d21d3q commented Feb 22, 2019

Should fix #4.
The are still deprecation warnings on build, but those are still related to socketcan

@Bobet21 Bobet21 mentioned this pull request Feb 22, 2019
@kais0r
Copy link

kais0r commented Sep 3, 2019

Hi. I also had problems when installing node-red-contrib-canbus via the node-red admin interface / palette manager.

Using node.js v12.9.1

in the actual node-red-contrib-canbus/package.json there is the part :
"dependencies": { "socketcan": "2.1.x", "random-js": "1.0.x" },

So.. what it then does: It installs socketcan v2.1.3 as another "submodule"
~/.node-red/node_modules/node-red-contrib-canbus/node_modules/socketcan

EDIT: (i typed this before my first coffee)

Would it be possible to go to socketcan v2.4.x ? I think this would fix that issue.
I will give it a try this week.
When i downgrade to node.js v8.16.0 it works. No errors compiling socketcan.

bdbc398 should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with the new version of socketcan in Node-red
2 participants