feature: cross-platform UI #39
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
maximilien-noal
force-pushed
the
feature/cross_platform
branch
from
7475d3b
to
4bd1e4b
Compare
|
Update: Two things to fix in RedrawScreen: wrong colors and wrong coords.
Also the MessageBox that confirms the user exiting the app arrives too late (the app has already closed) |
maximilien-noal
force-pushed
the
feature/cross_platform
branch
2 times, most recently
from
166e7cc
to
7c5c5ce
Compare
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
maximilien-noal
force-pushed
the
feature/cross_platform
branch
from
7c5c5ce
to
416f191
Compare
|
The only thing left to fix seems to be the keyboard. I can't skip the intro...? |
A big thumbs-up for explicitly paying attention to Linux-compatibility! |
I'm currently testing it under Linux ;) |
|
The test went successfully under Ubuntu. I had to be extra careful about Upper/Lower case file names as Linux distinguishes between them. But all went great ;) |
|
wow that is remarkable - running civ1 on Linux without an emulator! |
Description of Changes
Brings a cross-platform UI, thanks to AvaloniaUI.
Keeps the WinForms client as a comparison (for now).
Separates OpenCiv1 assembly from the UI.
Rationale behind Changes
Enables more contributions from people who don"t use Windows.
Enables the game to run on Linux, Mac, while still running on Windows.
The structure also enable the reuse of the OpenCiv1.UI assembly for a Blazor or Avalonia WASM project, and iOS and Android projects.
Suggested Testing Steps
Two things to fix in RedrawScreen: wrong colors and wrong coords.
Also the MessageBox that confirms the user exiting the app arrives too late (the app has already closed.