Fix for Godot 4.x #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakai93
requested changes
Dec 24, 2022
| Voronoi Godot integration for Godot 4.x | ||
| ======================================= | ||
|
|
||
| This fork upgrades the orginal [library](https://github.com/rakai93/godot_voronoi) to support Godot 4.x. |
There was a problem hiding this comment.
I guess this should be re-written to exclude "this fork" before being merged back.
| # Create voronoi generator | ||
| var points = PackedVector2Array([Vector2(0,0)]) | ||
| for i in 100: | ||
| randomize() |
There was a problem hiding this comment.
randomize() only needs to be called once before the loop
| func _draw(): | ||
| # Iterate over sites | ||
| for site in diagram.sites(): | ||
| randomize() |
|
Thank you for providing this PR! I personally don't use the project anymore and I guess it should be re-written as a GDExtension at some point, but for now I'm glad you continued the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Changes the type registration and header paths to play nice with the new Godot 4.x model.
! This will break the build for all Godot 3 branches including 3.5, however it should be able to build against the 3.x branch.
Build performed on Windows 11 and tested with the script described in README.md (! updated from original)