Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom loader #68

Merged
merged 2 commits into from
Sep 24, 2016
Merged

Custom loader #68

merged 2 commits into from
Sep 24, 2016

Conversation

bcbrian
Copy link
Contributor

@bcbrian bcbrian commented Sep 4, 2016

For consistency I added a simple way for others to add there own loader if the default is not sufficient for their app. This way contributors to the repo can also focus on the core functionality and worry about the piece of ux/ui. If I need to add more to make this merge worthy let me know :P

@rakannimer
Copy link
Owner

Hey thanks for the PR, I'm sure this will be helpful to lots of people.
Could you also add it as a defaultProp here : https://github.com/bcbrian/react-google-charts/blob/2326f0f4f0f645f636b127f409617a9b88037ae4/src/components/Chart.js#L291

@rakannimer rakannimer merged commit 6ffcf3e into rakannimer:master Sep 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants