Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require the target rbconfig rather than copypasting verbatim #233

Merged
merged 1 commit into from Jan 22, 2024
Merged

require the target rbconfig rather than copypasting verbatim #233

merged 1 commit into from Jan 22, 2024

Conversation

ParadoxV5
Copy link
Contributor

Fixes #232

@ParadoxV5
Copy link
Contributor Author

Greens CI: https://github.com/ParadoxV5/rake-compiler/actions/runs/7617624734

@ParadoxV5
Copy link
Contributor Author

The substitute mkmf.rb is also copy-pasted but possibly with replacements (not verbatim).
It allows us to continue supporting Ruby 1.8 – or do we?

@kou
Copy link
Member

kou commented Jan 22, 2024

I'll merge this but we don't mark your usage #232 (comment) as supported.

@kou kou merged commit 9b4edc0 into rake-compiler:master Jan 22, 2024
14 checks passed
@ParadoxV5 ParadoxV5 deleted the require_rbconfig branch January 23, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross Compile looks for Ruby headers in the wrong directory
2 participants
@ParadoxV5 @kou