Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GPIO directory based on actual device tree path #34

Merged
merged 2 commits into from
Apr 3, 2015

Conversation

VipSaran
Copy link
Contributor

@VipSaran VipSaran commented Mar 8, 2015

By testing the device tree directory we can detrermine whether to use the "old" /sys/devices/virtual/gpio path or to use the one used after update to kernel 3.18.x: /sys/class/gpio, so both configurations are supported.

@jfriend00
Copy link

This diff changes basic code formatting in ~50 places such that it is next to impossible to find what the functional change were to the code. This would be a much better submission if the diff was only the functional changes.

@VipSaran
Copy link
Contributor Author

VipSaran commented Mar 8, 2015

Fixed with commit VipSaran@2636804 (reverted the whitespace changes).

@jfriend00
Copy link

Finally found a way to see just the "net" diff: master...VipSaran:master

@VipSaran
Copy link
Contributor Author

VipSaran commented Mar 8, 2015

@jfriend00 you "found the way" becuse I added another commit to the pull request, just as I commented above.

@jfriend00
Copy link

@VipSaran - I know you added another commit. But even then, neither one of your commits made it easy to see the "net" diff so I had to find a way to see a diff between two non-sequential versions on Github. That's what I had to "find". I'm not a github expert so you weren't making it easy to see the meaningful diff which is what I cared about - even with your additional commit. When I found out how to do it, I thought I'd share so others could likewise just click on a link to see what functionally changed.

@VipSaran
Copy link
Contributor Author

VipSaran commented Mar 8, 2015

You don't have to be an expert. Just open Pull Request / Files Changed tab and you see the absolute difference between the upstream and the fork:
image

@lurch
Copy link

lurch commented Mar 21, 2015

AFAIK you shouldn't ever need to use /sys/devices/virtual/gpio and you should always just use /sys/class/gpio, regardless of whether DeviceTree is being used or not?
As raspberrypi/linux#791 (comment) explains.

@bestander
Copy link

👍 can this be merged please?

@jsavko
Copy link

jsavko commented Mar 25, 2015

This patch also makes it work with the Raspberry Pi 2 B. I was testing it last night.

rakeshpai added a commit that referenced this pull request Apr 3, 2015
Use GPIO directory based on actual device tree path
@rakeshpai rakeshpai merged commit c007832 into rakeshpai:master Apr 3, 2015
@rakeshpai
Copy link
Owner

Published to npm as 0.0.7. Thanks, @VipSaran @jfriend00 @jsavko.

@VipSaran
Copy link
Contributor Author

VipSaran commented Apr 3, 2015

Thanks @rakeshpai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants