-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GPIO directory based on actual device tree path #34
Conversation
This diff changes basic code formatting in ~50 places such that it is next to impossible to find what the functional change were to the code. This would be a much better submission if the diff was only the functional changes. |
Fixed with commit VipSaran@2636804 (reverted the whitespace changes). |
Finally found a way to see just the "net" diff: master...VipSaran:master |
@jfriend00 you "found the way" becuse I added another commit to the pull request, just as I commented above. |
@VipSaran - I know you added another commit. But even then, neither one of your commits made it easy to see the "net" diff so I had to find a way to see a diff between two non-sequential versions on Github. That's what I had to "find". I'm not a github expert so you weren't making it easy to see the meaningful diff which is what I cared about - even with your additional commit. When I found out how to do it, I thought I'd share so others could likewise just click on a link to see what functionally changed. |
AFAIK you shouldn't ever need to use |
👍 can this be merged please? |
This patch also makes it work with the Raspberry Pi 2 B. I was testing it last night. |
Use GPIO directory based on actual device tree path
Published to npm as 0.0.7. Thanks, @VipSaran @jfriend00 @jsavko. |
Thanks @rakeshpai |
By testing the device tree directory we can detrermine whether to use the "old"
/sys/devices/virtual/gpio
path or to use the one used after update to kernel 3.18.x:/sys/class/gpio
, so both configurations are supported.