Complete type hints and annotation comments #67
Conversation
|
Wow thank you @peter279k . You're so fast. 👍 I will check it, or maybe I will directly update it in your branch. |
src/Attribute.php
Outdated
| protected $alias; | ||
|
|
||
| /** @var mixed */ |
There was a problem hiding this comment.
This should be @var Validation. as per the constructor, nothing else except an instance of Validation is accepted.
src/Attribute.php
Outdated
| protected $required = false; | ||
|
|
||
| /** @var Attribute */ |
src/Attribute.php
Outdated
| * | ||
| * @return boolean | ||
| */ | ||
| public function isRequired(): bool | ||
| { | ||
| return $this->required === true; |
There was a problem hiding this comment.
Unrelated to this PR... But isn't required already a boolean? Why compare to true again.
There was a problem hiding this comment.
@adelowo , yeah....This condition === true is useless.
This should be return the value directly.
There was a problem hiding this comment.
Yes, it's useless, I'm not sure why I put it there 😄
src/Rule.php
Outdated
| * | ||
| * @return boolean | ||
| */ | ||
| public function isImplicit(): bool | ||
| { | ||
| return $this->implicit === true; |
| * | ||
| * @param mixed $value | ||
| * @return mixed | ||
| * @throws Exception |
There was a problem hiding this comment.
I think this should be @throws \Exception if it refers to the standard library's Exception class
| * Throw exception | ||
| * | ||
| * @param string $value | ||
| * @return Exception |
|
I think it's good for now. I will merge it. Thank you all. 😃 |
|
@emsifa, thank you for your commits and concern. I appreciate your help :). |
Changed log
PHPDocstyle and internal PHP type hints to complete the type hints for all codes insrcfolder.I'm not sure that these type hints or annotation comments are set the correct type hints/comments.
@emsifa, please check that and write down some comments/request changes.
Thanks.