Make pop/shift behaviour re deconting consistent

- Array.pop/shift now decont - sub pop/shift are now raw, as they don't need a decont check
rakudo · Apr 1, 2020 · 2edce41 · 2edce41
1 parent 6793713
commit 2edce41
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/core.c/Array.pm6 b/src/core.c/Array.pm6
@@ -847,7 +847,7 @@ my class Array { # declared in BOOTSTRAP
         Failure.new(X::Cannot::Empty.new(:$action,:what(self.^name)))
     }
 
-    method pop(Array:D:) is raw is nodal {
+    method pop(Array:D:) is nodal {
         nqp::if(
           self.is-lazy,
           self!lazy('pop from'),
@@ -860,7 +860,7 @@ my class Array { # declared in BOOTSTRAP
         )
     }
 
-    method shift(Array:D:) is raw is nodal {
+    method shift(Array:D:) is nodal {
         nqp::if(
           nqp::isconcrete(nqp::getattr(self,List,'$!reified'))
             && nqp::elems(nqp::getattr(self,List,'$!reified')),

diff --git a/src/core.c/array_operators.pm6 b/src/core.c/array_operators.pm6
@@ -44,10 +44,10 @@ multi sub circumfix:<[ ]>(Mu \x) {   # really only for [$foo]
 }
 
 proto sub pop($, *%) {*}
-multi sub pop(@a) { @a.pop }
+multi sub pop(@a) is raw { @a.pop }
 
 proto sub shift($, *%) {*}
-multi sub shift(@a) { @a.shift }
+multi sub shift(@a) is raw { @a.shift }
 
 proto sub push($, |) {*}
 multi sub push(\a,  \b) { a.push:   b }