Skip to content

Commit

Permalink
Make timing based performance tests opt in via RAKUDO_RUN_TIMING_TESTS
Browse files Browse the repository at this point in the history
It's easier to tell a hand full of core developers to set an environment
variable to opt into performance regression tests than to tell an unknown
number of unknown people to opt out of them for automated builds.

Fixes #3065
  • Loading branch information
niner committed May 2, 2020
1 parent 9cabea0 commit 31ffc2b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion appveyor.yml
Expand Up @@ -49,7 +49,6 @@ install:
- SET PATH=C:\strawberry\c\bin;C:\strawberry\perl\site\bin;C:\strawberry\perl\bin;%PATH%
- ECHO %RAKUDO_OPTIONS%
- CD %APPVEYOR_BUILD_FOLDER%
- SET RAKUDO_SKIP_TIMING_TESTS=1

# Testing
test_script:
Expand Down
4 changes: 2 additions & 2 deletions t/08-performance/99-misc.t
@@ -1,6 +1,6 @@
use Test;

my $skip = %*ENV<RAKUDO_SKIP_TIMING_TESTS> ?? 1 !! 0;
my $skip = %*ENV<RAKUDO_RUN_TIMING_TESTS> ?? 0 !! 3;

This comment has been minimized.

Copy link
@AlexDaniel

AlexDaniel May 2, 2020

Contributor

What's the meaning of 3? :)

This comment has been minimized.

Copy link
@niner

niner May 2, 2020

Author Collaborator

Skip 3 tests


plan 4 - $skip;

Expand All @@ -15,7 +15,7 @@ plan 4 - $skip;
is-deeply $f cmp ($ = $f), Same, 'eqaddr optimization for cmp exists'
}

{
unless $skip {
my int @a = ^2_000_000;
my $then = now;
my $result1 = @a.sum;
Expand Down

0 comments on commit 31ffc2b

Please sign in to comment.