Micro-optimize calls to HOW

Pre-cache `$_.HOW` where it's used more than once. Also fix a typo in ParametricRoleHOW.
rakudo · Jun 17, 2021 · 6e1cfe4 · 6e1cfe4
1 parent 4b99656
commit 6e1cfe4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/Perl6/Metamodel/CurriedRoleHOW.nqp b/src/Perl6/Metamodel/CurriedRoleHOW.nqp
@@ -133,10 +133,11 @@ class Perl6::Metamodel::CurriedRoleHOW
         # for $!curried_role.HOW.role_typecheck_list($obj) {
         #     nqp::push(@rtl, $_);
         # }
-        for self.roles_to_compose($obj) {
-            if $_.HOW.archetypes.composable() || $_.HOW.archetypes.composalizable() {
-                nqp::push(@rtl, $_);
-                for $_.HOW.role_typecheck_list($_) {
+        for self.roles_to_compose($obj) -> $role {
+            my $how := $role.HOW;
+            if $how.archetypes.composable() || $how.archetypes.composalizable() {
+                nqp::push(@rtl, $role);
+                for $how.role_typecheck_list($role) {
                     nqp::push(@rtl, $_);
                 }
             }

diff --git a/src/Perl6/Metamodel/ParametricRoleHOW.nqp b/src/Perl6/Metamodel/ParametricRoleHOW.nqp
@@ -237,7 +237,7 @@ class Perl6::Metamodel::ParametricRoleHOW
         # the case they're generic (role Foo[::T] is T { })
         for self.parents($obj, :local(1)) {
             my $p := $_;
-            if $_.HOW.archetypes.generic {
+            if $p.HOW.archetypes.generic {
                 $p := $p.HOW.instantiate_generic($p, $type_env);
             }
             $conc.HOW.add_parent($conc, $p, :hides(self.hides_parent($obj, $_)));