Add .append(IterationBuffer) methods to ReificationTargets

So that we have a better change of .append working in iterators.
rakudo · Mar 18, 2018 · 7d978fb · 7d978fb
1 parent 16daf02
commit 7d978fb
Showing 1 changed file with 20 additions and 0 deletions.
diff --git a/src/core/Array.pm6 b/src/core/Array.pm6
@@ -32,6 +32,22 @@ my class Array { # declared in BOOTSTRAP
             nqp::push($!target,
                 nqp::assign(nqp::p6scalarfromdesc($!descriptor), value));
         }
+
+        method append(IterationBuffer:D $buffer) {
+            nqp::if(
+              (my int $elems = nqp::elems($buffer)),
+              nqp::stmts(
+                (my int $i = -1),
+                nqp::while(
+                  nqp::islt_i(($i = nqp::add_i($i,1)),$elems),
+                  nqp::push($!target,nqp::assign(
+                    nqp::p6scalarfromdesc($!descriptor),
+                    nqp::atpos($buffer,$i)
+                  ))
+                )
+              )
+            )
+        }
     }
 
     my class ListReificationTarget {
@@ -45,6 +61,10 @@ my class Array { # declared in BOOTSTRAP
             nqp::push($!target,
                 nqp::decont(value));
         }
+
+        method append(IterationBuffer:D \buffer) {
+            nqp::splice($!target,buffer,nqp::elems($!target),0)
+        }
     }
 
     multi method clone(Array:D:) {