Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve array assignment inlinability
Prior to this, the ASSIGN-POS method was too large to inline on MoarVM, but it's really quite helpful for performance if it does inline. Since MoarVM doesn't factor in the size of nested inlines, however, then it's possible to get below the inline limit by splitting some of the code out into a private method, as done by this commit.
- Loading branch information
Showing
1 changed file
with
16 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8bd3e50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oddly enough, if I do the same change to the
int $pos
candidate, then it becomes slower:So I haven't done the
int $pos
candidate.8bd3e50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I decided to revert this commit and see if how much the improvement was. In fact it wasn't :-(
This was on MacOS. I wonder if that makes a difference. I could
--profile
the old version, but profiling the new version dies with::-(