Skip to content

Commit

Permalink
Use .pm6 under src/core/, not .pm
Browse files Browse the repository at this point in the history
We should really be setting a good example in Rakudo, plus this will be
easier on everyone whose editor defaults to Perl 6 highlights for .pm6
and Perl 5 highlights for .pm.
  • Loading branch information
jnthn committed Mar 2, 2018
1 parent 6117647 commit 98e575d
Show file tree
Hide file tree
Showing 230 changed files with 438 additions and 438 deletions.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion tools/build/install-core-dist.pl
Expand Up @@ -9,7 +9,7 @@
"Pod::To::Text" => "lib/Pod/To/Text.pm6",
"newline" => "lib/newline.pm6",
"experimental" => "lib/experimental.pm6",
"CompUnit::Repository::Staging" => "lib/CompUnit/Repository/Staging.pm",
"CompUnit::Repository::Staging" => "lib/CompUnit/Repository/Staging.pm6",
"Telemetry" => "lib/Telemetry.pm6",
"snapper" => "lib/snapper.pm6",
;
Expand Down
4 changes: 2 additions & 2 deletions tools/build/jvm_core_d_sources
@@ -1,2 +1,2 @@
src/core.d/core_prologue.pm
src/core.d/await.pm
src/core.d/core_prologue.pm6
src/core.d/await.pm6

5 comments on commit 98e575d

@lizmat
Copy link
Contributor

@lizmat lizmat commented on 98e575d Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to break: S10-packages/precompilation.t:

$ perl6 t/spec/S10-packages/precompilation.rakudo.moar
1..53
ok 1 -
ok 2 -
ok 3 -
ok 4 -
ok 5 - Diamond relationship
ok 6 -
ok 7 -
ok 8 -
ok 9 -
ok 10 -
ok 11 -
ok 12 -
ok 13 -
ok 14 -
ok 15 -
ok 16 -
ok 17 -
ok 18 -
ok 19 -
ok 20 -
ok 21 -
ok 22 - Twisty maze of dependencies, all different
not ok 23 - precompile exported cached sub # TODO RT #122896

Failed test 'precompile exported cached sub'

at /Users/liz/Github/rakudo.moar/t/spec/packages/Test/Util.pm (Test::Util) line 144

got status: 1

got err: "Cannot invoke this object (REPR: Null; VMNull)\n in block at /Users/liz/Github/rakudo.moar/install/share/perl6/sources/AAC61C0EC6F88780427830443A057030CAA33846 (experimental) line 10\n in block at /var/folders/7_/ndrzv7y14fj0zxjx3fy0hfjm0000gn/T/getout-66037-523419.code line 3\n\n"

expected err: ""

ok 24 - precompiled a parameterized role
ok 25 - precompiled a sub with params returning a proxy
ok 26 - precomp curried role compose
ok 27 - "need" survives "no precompilation"
ok 28 - tried to precompile all 3 modules
ok 29 -
ok 30 -
ok 31 -
ok 32 - RT123276
ok 33 - precomp of native array parameterization
not ok 34 - precompile load of both and identity check passed # TODO no 6model parametrics interning yet

Failed test 'precompile load of both and identity check passed'

at /Users/liz/Github/rakudo.moar/t/spec/packages/Test/Util.pm (Test::Util) line 144

got out: "False"

expected out: "True"

ok 35 - precomp of BEGIN using $*KERNEL and $*DISTRO
ok 36 - precomp of assignment to variable using subset type
ok 37 - no duplicate compilation error
ok 38 - GLOBAL symbols exist after re-precompiled
ok 39 - Can precompile modules before touching source file
ok 40 - Can precompile modules after touching source file
ok 41 - 1. changing SHA of dependency doesn't break re-precompilation
ok 42 - 2. changing SHA of dependency doesn't break re-precompilation
ok 43 - 1. change in source file of dependency detected
ok 44 - 2. change in source file of dependency detected
ok 45 - roles in precompiled modules recognize type names (run 0)
ok 46 - roles in precompiled modules recognize type names (run 1)
1..2
ok 1 - original content has correct value
ok 2 - modified content has updated
ok 47 - precompiled module constants get updated on change
ok 48 - no funny business with precompiled string strands (0)
ok 49 - no funny business with precompiled string strands (1)

FUDGED!

Looks like you planned 53 tests, but ran 49

@jnthn
Copy link
Member Author

@jnthn jnthn commented on 98e575d Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizmat Hmmm...though that test changed today; if I revert ad4aef0102e3d7dc2e986 (which changed that test file) in roast then it passes on HEAD.

@niner
Copy link
Collaborator

@niner niner commented on 98e575d Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion. I simply forgot to adapt the test count and somehow missed the failure message, too.

@lizmat
Copy link
Contributor

@lizmat lizmat commented on 98e575d Mar 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a related note: perhaps we should only accept .pm6 for modules in use statements in 6.d ? Wouldn't that definitely simplify matters and prevent and possible confusion if an same named .pm and .pm6 in the same directory?

@AlexDaniel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizmat I agree but comments on commits are lost easily. I drafted this ticket for further discussion: Raku/6.d-prep#8

Please sign in to comment.