Skip to content

Commit

Permalink
Remove commented out code, it's in version control so we can restore
Browse files Browse the repository at this point in the history
it when we need it
  • Loading branch information
pmurias committed Feb 1, 2019
1 parent 6e6c288 commit a7d7587
Showing 1 changed file with 0 additions and 36 deletions.
36 changes: 0 additions & 36 deletions src/Perl6/Pod.nqp
Original file line number Diff line number Diff line change
Expand Up @@ -186,27 +186,6 @@ class Perl6::Pod {
return $config;
}

our sub make-para($s) {
# TODO
# This is planned to be used to turn strings into paras, including
# chunks of formatting code (fc). Currently, there are strings that
# have fc that have not been properly turned into compiled fc
# blocks inside para contents. Some examples include table cells
# and defn block terms and definitions.
#
# NOTE This could be done in the grammar if we can untangle the
# first line of pod contents to treat as a separate
# entity and then recombine t with its original para string
# or make it the term for a defn block.
# However, this would still be needed for properly
# handling fc in table cells!
=begin comment
my @contents := pod_strings_from_matches(nqp::list($s));
@contents := serialize_array(@contents).compile_time_value;
return serialize_object('Pod::Block::Para', :@contents).compile_time_value;
=end comment
}

our sub defn($/, $blocktype) {
# produces a Perl 6 instance of Pod::Defn

Expand All @@ -232,10 +211,6 @@ class Perl6::Pod {
}

my $term := @children.shift;
=begin comment
# TODO for future change
$term := make-para($term);
=end comment

# The remaining @children array should have lines of text with
# an empty line being a paragraph separator. Combine
Expand Down Expand Up @@ -266,10 +241,6 @@ class Perl6::Pod {
my @contents := nqp::list($para);
@contents := serialize_array(@contents).compile_time_value;
my $obj := serialize_object('Pod::Block::Para', :@contents).compile_time_value;
=begin comment
# TODO for future change
my $obj := make-para($para);
=end comment
@pcontents.push($obj);
}
my $contents := serialize_array(@pcontents).compile_time_value;
Expand Down Expand Up @@ -1386,13 +1357,6 @@ class Perl6::Pod {
nqp::say($_) for @rows; # the original table as input
nqp::say("===end WARNING table $t input rows");
}
=begin comment
elsif $warns && $show_warning {
nqp::say("===WARNING: One or more tables evidence bad practice.");
nqp::say("== Set environment variable 'RAKUDO_POD_TABLE_DEBUG' for more details.");
$show_warning := 0;
}
=end comment
}

sub normalize_vis_col_sep_rows(@Rows) {
Expand Down

2 comments on commit a7d7587

@lizmat
Copy link
Contributor

@lizmat lizmat commented on a7d7587 Feb 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps @tbrowder should have been consulted about this? I know he's been doing a lot of work on pod the past year, and sometimes it's handy to have pointers to TODO sections in the code.

@tbrowder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish it could stay. That area is where Zoffix had some preferences and I still need to visit that area.

Thanks.

Please sign in to comment.