Give .chomp the possibility to specify a needle (#4739)

Basically: say "foobar".chomp("bar"); # foo say "foobar".chomp("baz"); # foobar
rakudo · Feb 12, 2022 · cccc3e8 · cccc3e8 · 0racle · Feb 14, 2022
1 parent 83b2417
commit cccc3e8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/core.c/Cool.pm6 b/src/core.c/Cool.pm6
@@ -109,8 +109,9 @@ my class Cool { # declared in BOOTSTRAP
     proto method flip(*%) {*}
     multi method flip(Cool:D:) { self.Str.flip }
 
-    proto method chomp(*%) {*}
+    proto method chomp($?, *%) {*}
     multi method chomp(Cool:D:) { self.Str.chomp }
+    multi method chomp(Cool:D: Cool:D $needle) { self.Str.chomp($needle.Str) }
 
     proto method chop(|)                {*}
     multi method chop(Cool:D:)          { self.Str.chop }

diff --git a/src/core.c/Str.pm6 b/src/core.c/Str.pm6
@@ -124,6 +124,12 @@ my class Str does Stringy { # declared in BOOTSTRAP
           self
         )
     }
+    multi method chomp(Str:D: Str:D $needle--> Str:D) {
+        my int $offset = nqp::sub_i(nqp::chars(self),nqp::chars($needle));
+        nqp::eqat(self,$needle,$offset)
+          ?? nqp::substr(self,0,$offset)
+          !! self
+    }
 
     multi method chop(Str:D: --> Str:D) {
         nqp::box_s(