Skip to content

Commit

Permalink
Remove proto: it breaks stuff
Browse files Browse the repository at this point in the history
Specifically S24-testing/11-plan-skip-all-subtests.t .  Looks like this
wasn't such a good beginners issue after all  :-(  This basically reverts
fa91b78 .  Sorry for the noise.
  • Loading branch information
lizmat committed Mar 2, 2019
1 parent 4eecb3c commit cd318fb
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions lib/Test.pm6
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ our sub todo_output is rw {
$todo_output
}

proto sub plan ($, Cool :$skip-all) {*}

multi sub plan (Cool:D :skip-all($reason)!) {
_init_io() unless $output;
$output.say: $indents ~ "1..0 # Skipped: $reason";
Expand Down

3 comments on commit cd318fb

@b2gills
Copy link
Contributor

@b2gills b2gills commented on cd318fb Mar 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably have worked if it was :( $?, Cool :$skip-all)

@lizmat
Copy link
Contributor Author

@lizmat lizmat commented on cd318fb Mar 3, 2019 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexDaniel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizmat release branch is behind these commits anyway, feel free to commit things to master. https://github.com/rakudo/rakudo/tree/release-2019.somewhen

Please sign in to comment.