Add sub versions of WHERE WHICH WHO (#5336)

They seem to have been forgotten, but are actually mentioned in some error messages. Feels they should be added for completeness sake. Also adapts tests accordingly.
rakudo · Aug 12, 2023 · dbde821 · dbde821
1 parent c1f7e4d
commit dbde821
Show file tree

Hide file tree

Showing 10 changed files with 27 additions and 6 deletions.
diff --git a/src/core.c/operators.pm6 b/src/core.c/operators.pm6
@@ -122,9 +122,12 @@ multi sub infix:<but>(Mu:U \obj, **@roles) {
 }
 
 # XXX Wants to be macros when we have them.
-only sub WHAT(Mu \x) { x.WHAT }
-only sub HOW (Mu \x) { x.HOW }
-only sub VAR (Mu \x) { x.VAR }
+only sub HOW (Mu \x)  { x.HOW   }
+only sub VAR (Mu \x)  { x.VAR   }
+only sub WHAT(Mu \x)  { x.WHAT  }
+only sub WHERE(Mu \x) { x.WHERE }
+only sub WHICH(Mu \x) { x.WHICH }
+only sub WHO(Mu \x)   { x.WHO   }
 
 proto sub infix:<...>(|) {*}
 multi sub infix:<...>(\a, Mu \b) {

diff --git a/t/02-rakudo/03-corekeys-6c.t b/t/02-rakudo/03-corekeys-6c.t
@@ -80,6 +80,9 @@ my @expected = (
   Q{&VAR},
   Q{&WHAT},
   Q{&WHENEVER},
+  Q{&WHERE},
+  Q{&WHICH},
+  Q{&WHO},
   Q{&abs},
   Q{&acos},
   Q{&acosec},

diff --git a/t/02-rakudo/03-corekeys-6d.t b/t/02-rakudo/03-corekeys-6d.t
@@ -80,6 +80,9 @@ my @expected = (
     Q{&VAR},
     Q{&WHAT},
     Q{&WHENEVER},
+    Q{&WHERE},
+    Q{&WHICH},
+    Q{&WHO},
     Q{&abs},
     Q{&acos},
     Q{&acosec},

diff --git a/t/02-rakudo/03-corekeys-6e.t b/t/02-rakudo/03-corekeys-6e.t
@@ -82,6 +82,9 @@ my @expected = (
     Q{&VAR},
     Q{&WHAT},
     Q{&WHENEVER},
+    Q{&WHERE},
+    Q{&WHICH},
+    Q{&WHO},
     Q{&abs},
     Q{&acos},
     Q{&acosec},

diff --git a/t/02-rakudo/03-corekeys.t b/t/02-rakudo/03-corekeys.t
@@ -83,6 +83,9 @@ my @allowed =
       Q{&VAR},
       Q{&WHAT},
       Q{&WHENEVER},
+      Q{&WHERE},
+      Q{&WHICH},
+      Q{&WHO},
       Q{&abs},
       Q{&acos},
       Q{&acosec},

diff --git a/t/02-rakudo/04-settingkeys-6c.t b/t/02-rakudo/04-settingkeys-6c.t
@@ -79,6 +79,9 @@ my %allowed = (
     Q{&VAR},
     Q{&WHAT},
     Q{&WHENEVER},
+    Q{&WHERE},
+    Q{&WHICH},
+    Q{&WHO},
     Q{&abs},
     Q{&acos},
     Q{&acosec},

diff --git a/t/02-rakudo/04-settingkeys-6e.t b/t/02-rakudo/04-settingkeys-6e.t
@@ -79,6 +79,9 @@ my %allowed = (
     Q{&VAR},
     Q{&WHAT},
     Q{&WHENEVER},
+    Q{&WHERE},
+    Q{&WHICH},
+    Q{&WHO},
     Q{&abs},
     Q{&acos},
     Q{&acosec},

diff --git a/t/02-rakudo/07-implementation-detail-6.c.t b/t/02-rakudo/07-implementation-detail-6.c.t
@@ -10,7 +10,7 @@ sub non-implementation(\base, \matcher) {
       .map( *.value.name )
 }
 
-my @UPPER = <DYNAMIC-FALLBACK EVAL EVALFILE HOW NYI RUN-MAIN VAR WHAT>;
+my @UPPER = <DYNAMIC-FALLBACK EVAL EVALFILE HOW NYI RUN-MAIN VAR WHAT WHERE WHICH WHO>;
 
 my @lower = ("",<<
   abs acos acosec acosech acosh acotan acotanh all any append

diff --git a/t/02-rakudo/07-implementation-detail-6.d.t b/t/02-rakudo/07-implementation-detail-6.d.t
@@ -10,7 +10,7 @@ sub non-implementation(\base, \matcher) {
       .map( *.value.name )
 }
 
-my @UPPER = <DYNAMIC-FALLBACK EVAL EVALFILE HOW NYI RUN-MAIN VAR WHAT>;
+my @UPPER = <DYNAMIC-FALLBACK EVAL EVALFILE HOW NYI RUN-MAIN VAR WHAT WHERE WHICH WHO>;
 
 my @lower = ("",<<
   abs acos acosec acosech acosh acotan acotanh all any append

diff --git a/t/02-rakudo/07-implementation-detail-6.e.t b/t/02-rakudo/07-implementation-detail-6.e.t
@@ -10,7 +10,7 @@ sub non-implementation(\base, \matcher) {
       .map( *.value.name )
 }
 
-my @UPPER = <DYNAMIC-FALLBACK EVAL EVALFILE HOW NYI RUN-MAIN VAR WHAT>;
+my @UPPER = <DYNAMIC-FALLBACK EVAL EVALFILE HOW NYI RUN-MAIN VAR WHAT WHERE WHICH WHO>;
 
 my @lower = ("",<<
   abs acos acosec acosech acosh acotan acotanh all any append