Make Setty.roll about 11x faster

By using R:Q.ROLL, which prevents having to build lists.
rakudo · May 21, 2017 · e6192ca · e6192ca
1 parent 0e9ee0d
commit e6192ca
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/core/Setty.pm b/src/core/Setty.pm
@@ -156,7 +156,13 @@ my role Setty does QuantHash {
     multi method pick(Setty:D: $count) { self.hll_hash.values.pick($count) }
 
     proto method roll(|) { * }
-    multi method roll(Setty:D:)       { self.hll_hash.values.roll()       }
+    multi method roll(Setty:D:) {
+        nqp::if(
+          $!elems,
+          nqp::iterval(Rakudo::QuantHash.ROLL($!elems)),
+          Nil
+        )
+    }
     multi method roll(Setty:D: $count) { self.hll_hash.values.roll($count) }
 
     multi method EXISTS-KEY(Setty:D: \k --> Bool:D) {