Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some issue exposed by Math::FFT::Libfftw3 #2682

Closed
AlexDaniel opened this issue Feb 8, 2019 · 2 comments · Fixed by #3250
Closed

Some issue exposed by Math::FFT::Libfftw3 #2682

AlexDaniel opened this issue Feb 8, 2019 · 2 comments · Fixed by #3250
Labels
ecosystem modules regression Issue did not exist previously tests needed Issue is generally resolved but tests were not written yet

Comments

@AlexDaniel
Copy link
Contributor

See Raku/ecosystem-unbitrot#468

Math::FFT::Libfftw3 – Fail, Bisected: rakudo/rakudo@ccf350e

Ping @lizmat.
@AlexDaniel AlexDaniel added regression Issue did not exist previously BLOCKER Preventing the next release of rakudo, or just needing attention before the release labels Feb 8, 2019
@lizmat lizmat added the tests needed Issue is generally resolved but tests were not written yet label Feb 11, 2019
@dogbert17
Copy link

Fixed by lizmat++ with 0d2658b

@AlexDaniel AlexDaniel removed the BLOCKER Preventing the next release of rakudo, or just needing attention before the release label Feb 11, 2019
@Altai-man
Copy link
Member

So the issue was that [ ] postcircumfix for whateverstar was using an obsolete method call when called for CArray. The golf is:

    my @t2682 := CArray[int32].new(1,2,3);
    is-deeply @t2682[0..*-2], (1,2), 'Indexing with WhateverStar works on CArray';

^ this is added as a rakudo test.

Altai-man added a commit to Altai-man/rakudo that referenced this issue Oct 19, 2019
@Altai-man
Test indexing with whatever for CArray
bc8ca4e 
Closes rakudo#2682
@Altai-man Altai-man mentioned this issue Oct 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ecosystem modules regression Issue did not exist previously tests needed Issue is generally resolved but tests were not written yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test indexing with whatever for CArray Altai-man/rakudo
5 participants
@lucasbuchala @lizmat @AlexDaniel @Altai-man @dogbert17