Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't require package with globally existing classnames #4488

Closed
Leont opened this issue Aug 6, 2021 · 5 comments
Closed

Can't require package with globally existing classnames #4488

Leont opened this issue Aug 6, 2021 · 5 comments

Comments

@Leont
Copy link
Contributor

Leont commented Aug 6, 2021

The Problem

Given this Foo.rakumod:

unit package Foo;

class Version {
}

These will work:

  • raku -e 'use Foo'
  • raku -e 'need Foo'
  • raku -e 'require ::("Foo")'

but this will not:

raku -e 'require Foo'

P6M Merging GLOBAL symbols failed: duplicate definition of symbol Version
  in block <unit> at -e line 1

My guess would be that this related to the placeholder package that require installs.

Environment

Welcome to 𝐑𝐚𝐤𝐮𝐝𝐨™ v2021.07.
Implementing the 𝐑𝐚𝐤𝐮™ programming language v6.d.
Built on MoarVM version 2021.07.
@ugexe
Copy link
Member

ugexe commented Aug 6, 2021

My hunch is this behavior is related to #2789 since it (the noted behavior/error) was not in the 2019.03.1 release but started for the 2019.07 release onward which corresponds with when that PR was merged

@tony-o
Copy link
Collaborator

tony-o commented Aug 17, 2021

Fix is incoming, pending spectests

ugexe added a commit to ugexe/zef that referenced this issue Aug 25, 2021
@Leont
Copy link
Contributor Author

Leont commented Oct 2, 2021

Fix is incoming, pending spectests

@tony-o did this get fixed?

tony-o added a commit that referenced this issue Oct 19, 2021
@tony-o
Copy link
Collaborator

tony-o commented Oct 19, 2021

@Leont forgot to push the fix. Will merge once spectest finishes

tony-o added a commit that referenced this issue Oct 19, 2021
This reverts commit d0a739f.
tony-o added a commit that referenced this issue Oct 19, 2021
tony-o added a commit that referenced this issue Oct 20, 2021
@tony-o
Copy link
Collaborator

tony-o commented Oct 20, 2021

@Leont this is merged in master -

@Leont Leont closed this as completed Oct 21, 2021
codesections pushed a commit to codesections-forks/rakudo that referenced this issue Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants