Optimize Actions.(dec|hex|oct|bin)int() #1021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a string_to_int that uses nqp::radix instead of nqp::radix_I.
Then call that from Actions.(dec|hex|oct|bin)int() instead of
string_to_bigint when the number of chars in the string to be converted
is small enough that it couldn't cause overflow.
Passes
make m-spectest
.If there was a way to tell whether we're on a 32 or 64 bit system in
Actions.nqp the number of chars at which we switch to nqp::radix_I
could be increased.