Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix subset isa method on a subset. #1165

Merged
merged 1 commit into from Sep 19, 2017
Merged

Conversation

dwarring
Copy link
Contributor

perl6 -e'subset S of Int; subset S2 of S; say S2.isa(S)'

now returns True. fully resolves RT #132073

perl6 -e'subset S of Int; subset S2 of S; say S2.isa(S)'

now returns True. fully resolves RT #132073
@zoffixznet
Copy link
Contributor

zoffixznet commented Sep 19, 2017

Does perl6 -e'subset S of Int; subset S3 of S; subset S2 of S; say S2.isa(S3)' return False?

Not very familiar with this part of codebase, but looks like the added condition simply checks whether the given type is a subset… any subset.

@dwarring
Copy link
Contributor Author

Yes, that returns False.
I borrowed the added logic from the type_check method

@zoffixznet zoffixznet merged commit b66f5e1 into rakudo:nom Sep 19, 2017
@zoffixznet
Copy link
Contributor

👍 Thanks!

@dwarring dwarring deleted the subset-isa2 branch September 22, 2017 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants