Issue 1305: Throw exception on attempted assign to range pos #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be just a single, non-multi method, no? |
Range is immutable as mentioned in the spec <https://github.com/perl6/specs/blob/master/S02-bits.pod#immutable-types> Assignment failed before, but this provides a clearer error message. Addresses [Issue rakudo#1305](rakudo#1305).
jstuder-gh
force-pushed
the
issue_1305
branch
from
42f14ba
to
51e0aa0
Compare
|
You're right. I've modified the PR. |
Altai-man
added a commit
that referenced
this pull request
Sep 25, 2020
NQP bump brought: Raku/nqp@2020.08.2-18-gb28db8914...2020.08.2-28-g95b85c5f6 95b85c5f6 [MoarVM Bump] Brings 13 commits 41f143f68 Merge pull request #670 from usev6/nqp_singleton 37963db1b Merge pull request #669 from usev6/jvm_decoder 2944fc668 Run two more decoder tests on all backends bb97ec4e9 Run five more decoder tests on all backends cb28641ce Unify tests for streaming decoder fc058f84e [JVM] Use singleton object for vmnull 3199f99aa Merge pull request #667 from patrickbkr/always-update-digest-sha 7f03a2ccb Include P6QRegex sources in common sources afbb60f62 Update digest-sha on any source change MoarVM bump brought: MoarVM/MoarVM@2020.08-91-g590bac47e...2020.08-104-g25c70bfe0 25c70bfe0 Hash tables must also resize if the max probe distance is hit on an empty slot. 34e0fb55e Merge pull request #1343 from MoarVM/sparc 39743de41 Merge pull request #1347 from MoarVM/MVMHash-copy_to-marking-bug 738024f9c Merge pull request #1341 from patrickbkr/fix-root-file-executable 21992e6f0 Merge pull request #1346 from MoarVM/optimize-boxed-float-boolification 124fe2be9 copy_to should call MVM_gc_write_barrier with the *new* key's address. 1fdfdf59c Fix endless recursion and segfault in dump_p6opaque 322c2e0b4 Comments and ASCII diagrams explaining the hash structure. 50d3311c7 Better specialize boolification of boxed Num 96d32a1ad Don't duplicate file existence checks b243d0178 Fix MVM_file_isexecutable() when being root 077219993 Correctly align object references (ie pointers) in P6opaque object bodies. 87ad486f3 sparc32 does not support unaligned 32 bit reads or writes.
Kaiepi
pushed a commit
to Kaiepi/rakudo
that referenced
this pull request
Sep 28, 2020
NQP bump brought: Raku/nqp@2020.08.2-18-gb28db8914...2020.08.2-28-g95b85c5f6 95b85c5f6 [MoarVM Bump] Brings 13 commits 41f143f68 Merge pull request rakudo#670 from usev6/nqp_singleton 37963db1b Merge pull request rakudo#669 from usev6/jvm_decoder 2944fc668 Run two more decoder tests on all backends bb97ec4e9 Run five more decoder tests on all backends cb28641ce Unify tests for streaming decoder fc058f84e [JVM] Use singleton object for vmnull 3199f99aa Merge pull request rakudo#667 from patrickbkr/always-update-digest-sha 7f03a2ccb Include P6QRegex sources in common sources afbb60f62 Update digest-sha on any source change MoarVM bump brought: MoarVM/MoarVM@2020.08-91-g590bac47e...2020.08-104-g25c70bfe0 25c70bfe0 Hash tables must also resize if the max probe distance is hit on an empty slot. 34e0fb55e Merge pull request rakudo#1343 from MoarVM/sparc 39743de41 Merge pull request rakudo#1347 from MoarVM/MVMHash-copy_to-marking-bug 738024f9c Merge pull request rakudo#1341 from patrickbkr/fix-root-file-executable 21992e6f0 Merge pull request rakudo#1346 from MoarVM/optimize-boxed-float-boolification 124fe2be9 copy_to should call MVM_gc_write_barrier with the *new* key's address. 1fdfdf59c Fix endless recursion and segfault in dump_p6opaque 322c2e0b4 Comments and ASCII diagrams explaining the hash structure. 50d3311c7 Better specialize boolification of boxed Num 96d32a1ad Don't duplicate file existence checks b243d0178 Fix MVM_file_isexecutable() when being root 077219993 Correctly align object references (ie pointers) in P6opaque object bodies. 87ad486f3 sparc32 does not support unaligned 32 bit reads or writes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Range is immutable as mentioned in the spec
https://github.com/perl6/specs/blob/master/S02-bits.pod#immutable-types
Assignment failed before, but this provides a clearer error message.