Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RT#127051 #1359

Merged
merged 2 commits into from Jan 3, 2018
Merged

Fix RT#127051 #1359

merged 2 commits into from Jan 3, 2018

Conversation

titsuki
Copy link
Contributor

@titsuki titsuki commented Jan 3, 2018

Hi,
I fixed RT#127051: https://rt.perl.org/Public/Bug/Display.html?id=127051

The changes are:

  • Add smileys to make sure that rational calculation only uses instances not type objects [9910b39]
  • Add tests for exception handling of rational calculation [9adc58c]

…s not type objects

Fixes RT#127051: https://rt.perl.org/Public/Bug/Display.html?id=127051

This fix keeps both DIVIDE_NUMBERS and DON'T_DIVIDE_NUMBERS from accepting type object and makes the exception handling more proper.
For example, multi sub infix:</>(Int:D \a, Int:D \b) can detect the denominator of 1/1.WHAT is a type object and cause an exception before calling DIVIDE_NUMBERS.
@lizmat lizmat merged commit 6373961 into rakudo:master Jan 3, 2018
@lizmat
Copy link
Contributor

lizmat commented Jan 3, 2018

Thank you!

@titsuki
Copy link
Contributor Author

titsuki commented Jan 3, 2018

Thanks for merging!

@titsuki titsuki deleted the fix-rat-LTA branch January 3, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants