Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RT#126669 #1395

Merged
merged 2 commits into from Jan 13, 2018
Merged

Fix RT#126669 #1395

merged 2 commits into from Jan 13, 2018

Conversation

titsuki
Copy link
Contributor

@titsuki titsuki commented Jan 13, 2018

Hi,

I fixed RT#126669: https://rt.perl.org/Public/Bug/Display.html?id=126669

The changes are:

  • Add error messages for Perl5-style pragma (e.g., "use 6.0", "need 6.0") [2dc93ac]
  • Add tests for X::Undeclared::Symbols exception for when Perl5-style pragma is used [4ec5936]

@titsuki
Add error messages for Perl5-style pragma (e.g., "use 6.0", "need 6.0")
2dc93ac 
Fixes RT#126669: https://rt.perl.org/Public/Bug/Display.html?id=126669

When the name of an undeclared routine matches any keys of the table $obs, it shows the associated error message.
This fix leverages this table; it stores "use" and "need" each as a key and their associated error messages each as a value.
@titsuki
Add tests for X::Undeclared::Symbols exception for when Perl5-style p…
4ec5936 
…ragma is used

Fixes RT#126669: https://rt.perl.org/Public/Bug/Display.html?id=126669
@titsuki titsuki changed the title FIx RT#126669 Fix RT#126669 Jan 13, 2018
@lizmat lizmat merged commit b2bf8e1 into rakudo:master Jan 13, 2018
@lizmat
Copy link
Contributor

lizmat commented Jan 13, 2018

Thanks!

@titsuki
Copy link
Contributor Author

titsuki commented Jan 13, 2018

Thanks for merging!

@titsuki titsuki deleted the fix-use-lta branch January 13, 2018 14:12
@zoffixznet
Copy link
Contributor

FWIW, need does not load the language and just silently ignores the version:

<Zoffix_> m: need v6.z
<camelia> rakudo-moar 1e8c9762e: ( no output )
<Zoffix_> m: use v6.z
<camelia> rakudo-moar 1e8c9762e: OUTPUT: «===SORRY!=== Error while compiling <tmp>␤No compiler available for Perl v6.z␤at <tmp>:1␤------> use v6.z⏏<EOL>␤»

There's a ticket proposing removal of <version> token from its parse

@titsuki
Copy link
Contributor Author

titsuki commented Jan 14, 2018

@zoffixznet
Thanks!
I'll send a PR for RT132214.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@titsuki @lizmat @zoffixznet