Issue 1397: Reifiy pending elements in Seq prior to rotor call #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passes existing spectest. Will need to write additional tests if accepted. |
|
I don't think we need to cache the Seq. The crash in the ticket is because Rotor iterator violates Iterator protocol and pulls one too many times. Looks like the previous fix for the same crash did not address the Something similar needs to be applied to around this area I wrote a test to cover the bug you can use. |
Rakudo::Iterator::Rotor was calling .pull-one too many times causing error. This type of error has been encountered before, on another code-path involving Rakudo::Iterator::Batch. zoffix++ for pointing this out. Addresses [Issue 1397](rakudo#1397) See commit for more details: bcd902a
jstuder-gh
force-pushed
the
issue_1397_ords_rotor
branch
from
22c84ed
to
4a82b4b
Compare
|
Caching did resolve the error in this instance, but your way is better and resolves the underlying issue. I've updated the branch with the new fix. |
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are instances where a Seq is newly created and its elements have
not been iterated/cached yet. Calling a method like rotor that
anticipates such elements will fail. Add a method in Seq that intercepts
the Seq and reifies any pending elements prior to dispatching it to the
Any rotor method for processing.
Addresses Issue 1397