GH#1758: Only suggest a submethod if it's local #1791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterDuke17
reviewed
May 2, 2018
MasterDuke17
reviewed
May 2, 2018
This avoids us suggesting a submethod from a parent class, which would always result into an error.
|
See also #1873. |
| throws-like q| class GH1758_2 { submethod x { };}; GH1758_2.new._ |, | ||
| X::Method::NotFound, | ||
| message => /"Did you mean 'x'"/, | ||
| 'Ancestor submethods should not be typo-suggested'; |
There was a problem hiding this comment.
And I'd suggest changing this description to something like 'Submethods at the same inheritance level should be suggested'
|
Also, there are conflicts now. Can you please check? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids us suggesting a submethod from a parent class, which would
always result into an error.