Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use path-spec instead of path for module-not-found errors #2660

Merged
merged 1 commit into from Jan 30, 2019
Merged

Use path-spec instead of path for module-not-found errors #2660

merged 1 commit into from Jan 30, 2019

Conversation

ugexe
Copy link
Member

@ugexe ugexe commented Jan 30, 2019

The path portion of the path-spec is often not enough to debug what wasn't found. This change includes the entire path-spec when giving an error for e.g. use NotFound;

$ install/bin/perl6 -I . -e 'use NotFound;'
===SORRY!===
Could not find NotFound at line 1 in:
    file#/Users/ugexe/repos/rakudo
    inst#/Users/ugexe/.perl6
    inst#/Users/ugexe/repos/rakudo/install/share/perl6/site
    inst#/Users/ugexe/repos/rakudo/install/share/perl6/vendor
    inst#/Users/ugexe/repos/rakudo/install/share/perl6
    ap#
    nqp#
    perl5#

It might be best to remove the empty repos from output, but they are used in determining the other repo's repo-id so their removal should be considered outside of this PR.

The path portion of the path-spec is often not enough to debug
what wasn't found. This change includes the entire path-spec
when giving an error for e.g. `use NotFound;`
@niner niner merged commit 82fde76 into rakudo:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants