Fix build on Windows #2802
Merged
Fix build on Windows #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely on the build configuration of MoarVM more when building the libraries and executables in rakudo instead of hard coding stuff.
when nmake is called without any argument it tries to execute the first target. Because nmake knows nothing about .PHONY it sees it as a normal target and tries to execute that. So we have to put the .NOTPARALLEL target after the 'all' target.
It seems the NQP config variable 'moar::ldimp' is '' instead of undefined in rakudo irrespective of it being set to undef in MoarVM/build/setup.pm where it originates. Thus the check needs to be different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-lmoaroption with some templating that picks the correct option also on Windows.I tested this on MinGW/gcc/gmake, MSVC/cl/nmake and linux/gcc/make.