Give SetHash a set/unset method #2942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by seeing things like:
%sethash{$_} = True for @to-be-added;
in the wild. Instead, one can now do:
%sethash.set(@to-be-added);
%sethash.unset(@to-be-removed);
which is about 4x as fast.
|
Isn't it work for the optimizer? |
|
Yes, Eventually. I think it will be quite some years before the optimizer is fast and smart enough to optimize this. |
lizmat
added a commit
that referenced
this pull request
Feb 4, 2020
As proposed about 8 months ago in: #2942 Since nobody had a big objection against it, and I think it will make working with SetHashes much easier, I decided to just put it in (as the Pull Request had bitrotted). Please revert if disagreeing.
|
Implemented with 6df78ca3ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by seeing things like:
in the wild. Instead, one can now do:
which is about 4x as fast.