Fix detection of current language version #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For unknown reason `nqp::getcomp('perl6').language_version` sometimes
returns `6.d` at compile time even though `use v6.e.PREVIEW` pragma is
used. To get around this problem `getcomp` is now last-resort path.
First `nqp::p6clientcorever` is used to work for type objects created
dynamically at run time; then `World` object is used to find
`CORE-SETTING-REV` symbol to work at compile-time.
rakudo#3141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unknown reason
nqp::getcomp('perl6').language_versionsometimesreturns
6.dat compile time even thoughuse v6.e.PREVIEWpragma isused. To get around this problem
getcompis now last-resort path.First
nqp::p6clientcoreveris used to work for type objects createddynamically at run time; then
Worldobject is used to findCORE-SETTING-REVsymbol to work at compile-time.#3141