Main single positional #370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a named array argument would fail to dispatch if the corresponding command line switch only appeared once.
This mostly bypasses the dispatcher, but I don't see a different way to solve it. Feedback and improvements welcome.
| if %($n).grep: { .value ~~ Positional } -> @pairs { | ||
| for @pairs -> $pair { | ||
| for @matching_candidates -> $cand { | ||
| my @param = $cand.signature.params.grep: { .named_names eq $pair.key }; |
There was a problem hiding this comment.
.named_names returns an array. E.g.:
sub foo(:name1(:name2(:$name3))) {}
say &foo.signature.params[0].named_names.perl
outputs Array.new("name3", "name2", "name1")
|
Closing this for now. I don't think the approach is the best, and as Mouq mentions there's a few cases that have to be speculated about first anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings handling of arguments to the programm more in line with what Getopt::Long would do. I.e. a parameter that is declared as Scalar (like in «sub MAIN(:$foo) { ... }») cannot be dispatched to by multiple occurences of a command line switch of the same name.