Partial fix of mixing in a role with attributes into a NQP class #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix is partial as parameterized roles with an attribute still throw when role parameter is assigned to the attribute: role Foo[$p] {
has $.foo = $p;
}
"42".HOW does Foo["The Answer"];With this PR the exception produced is |
|
Upd Full fix includes Raku/nqp#650 |
vrurg
added a commit
to Raku/roast
that referenced
this pull request
Jul 30, 2020
Requires Raku/nqp#650 and rakudo/rakudo#3834 to pass. I have removed trait `described` because the final implementation of traits doesn't need covering two different trait routine signatures. Renamed the role from `description` to `Description` because trait `is` can't tell the difference between the trait and the role to pun because of the same name used for both. Because a trait is applied to a parametric role, not the role group, test against the first group candidate.
It makes Attribute incompatible with Metamodel and other NQP classes via a mixin. `can` is to be avoided too because KnowHOW doesn't have it.
In a rare case the exception can be thrown for a KnowHOW type object or instance. The problem is that method `methods` of KnowHOW returns not a list of code objects but the method table itself in a hash form.
vrurg
force-pushed
the
roast_657_attr_fix
branch
from
d53573f
to
9e51d01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Raku role with an attribute is mixed into a metamodel or NQP class rakudo throws
X::Method::NotFound:This PR is a fix. It also fixes
X::Method::NotFoundexception message code failing onKnowHOWobjects because theirmethodsmethod returns the method table, not a list of methods.