Replace all simple nqp::if(42,foo,bar) with ternaries #3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If memory serves me well, about 1.5 years ago, optimizations in Rakudo made the construct: 42 ?? foo !! bar equally fast as the nqp equivalent: nqp::if(42,foo,bar) This commit converts all of the simple nqp::if() structures in the core.c setting to their ternary equivalents. - binary size of CORE.c.setting.moarvm file is unchanged (almost) - speed should be on par with the nqp::if() equivalents - readability of the core setting should be improved. make test and make spectest clean.
AlexDaniel
approved these changes
Oct 14, 2020
AlexDaniel
reviewed
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If memory serves me well, about 1.5 years ago, optimizations in
Rakudo made the construct:
42 ?? foo !! bar
equally fast as the nqp equivalent:
nqp::if(42,foo,bar)
This commit converts all of the simple nqp::if() structures in the
core.c setting to their ternary equivalents.
make test and make spectest clean.